Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ESSNTL-4486): Update API functions names #1858

Merged
merged 2 commits into from
May 10, 2023

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented May 10, 2023

After https://github.com/RedHatInsights/insights-inventory-frontend/pull/1847/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R19 upgrade, it turned out some javascript-clients functions changed their naming. This updates the places where incorrect function were called.

How to test

Deploy the PR, navigate to Inventory and try to change display name, ansible name or delete host. The operations must be completed successfully and without errors.

@gkarat gkarat added the bug Something isn't working label May 10, 2023
@gkarat gkarat requested a review from a team as a code owner May 10, 2023 09:51
@gkarat gkarat self-assigned this May 10, 2023
@gkarat
Copy link
Contributor Author

gkarat commented May 10, 2023

/retest

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (9488163) 64.81% compared to head (43e9e2b) 64.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1858   +/-   ##
=======================================
  Coverage   64.81%   64.81%           
=======================================
  Files         136      136           
  Lines        3425     3425           
  Branches     1030     1030           
=======================================
  Hits         2220     2220           
  Misses       1205     1205           
Impacted Files Coverage Δ
src/store/actions.js 100.00% <ø> (ø)
src/store/inventory-actions.js 89.79% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkarat gkarat merged commit c7d3a6b into RedHatInsights:master May 10, 2023
@gkarat gkarat deleted the essntl-4486-fix-1 branch May 10, 2023 14:09
@gkarat
Copy link
Contributor Author

gkarat commented May 10, 2023

🎉 This PR is included in version 1.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants